Syllable Forum Index Syllable
Syllable Forums
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

TCP no route error handling

 
Post new topic   Reply to topic    Syllable Forum Index -> Bugs - Fixed
View previous topic :: View next topic  
Author Message
c0x



Joined: 13 Oct 2007
Posts: 75

PostPosted: Tue Oct 16, 2007 6:29 am    Post subject: TCP no route error handling Reply with quote

Hi!

In the tcp_connect function (net/tcp.c) when the kernel is unable to find a route to the detination address no error is reported for the user.
The function just returns zero because nError was set to zero in line #316 by tcp_sync(). I think there should be an "nError = -ENETUNREACH;" ( dunno if this one is the right error code..) before line #335.

c0x
Back to top
View user's profile Send private message
Kaj
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 2207
Location: Friesland

PostPosted: Tue Oct 16, 2007 7:12 am    Post subject: Reply with quote

Nice finds, c0x. Smile
Back to top
View user's profile Send private message Visit poster's website
c0x



Joined: 13 Oct 2007
Posts: 75

PostPosted: Tue Oct 16, 2007 7:35 am    Post subject: Reply with quote

Thanks Smile
Back to top
View user's profile Send private message
Kaj
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 2207
Location: Friesland

PostPosted: Tue Oct 16, 2007 7:39 am    Post subject: Reply with quote

Quite a few popular network applications have stopped working in their newer versions over the past years, so I hope things like this will fix some of them.
Back to top
View user's profile Send private message Visit poster's website
c0x



Joined: 13 Oct 2007
Posts: 75

PostPosted: Tue Oct 16, 2007 7:43 am    Post subject: Reply with quote

If you tell me the names of the apps i could have a look on them if these problems didn't change anything...
Back to top
View user's profile Send private message
Kaj
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 2207
Location: Friesland

PostPosted: Tue Oct 16, 2007 11:08 am    Post subject: Reply with quote

They're the packages marked broken in the Builder network pack profile:

[url]http://syllable.cvs.sourceforge.net/syllable/syllable/system/apps/utils/Builder/profiles/net-pack?revision=1.23&view=markup[/url]

Links requires updates to its Syllable GUI, but the others are having problems with Syllable while older versions worked. You can use Builder to compile these programs and test them.
Back to top
View user's profile Send private message Visit poster's website
Vanders
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 849

PostPosted: Mon Nov 26, 2007 8:27 am    Post subject: Re: TCP no route error handling Reply with quote

[quote="c0x"]
In the tcp_connect function (net/tcp.c) when the kernel is unable to find a route to the detination address no error is reported for the user. The function just returns zero because nError was set to zero in line #316 by tcp_sync(). I think there should be an "nError = -ENETUNREACH;" ( dunno if this one is the right error code..) before line #335.
[/quote]

It took me a while but you may be pleased to know that the code now does exactly that, and yes ENETUNREACH [url=http://www.opengroup.org/onlinepubs/000095399/functions/connect.html]is the correct return value[/url] for that situation!
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Syllable Forum Index -> Bugs - Fixed All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group