Syllable Forum Index Syllable
Syllable Forums
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Transferrer local & remote views vanish

 
Post new topic   Reply to topic    Syllable Forum Index -> Bugs - Fixed
View previous topic :: View next topic  
Author Message
dkent



Joined: 07 Aug 2008
Posts: 6
Location: Australia

PostPosted: Mon May 31, 2010 7:41 am    Post subject: Transferrer local & remote views vanish Reply with quote

Symtom:
Move the splitter center bar side to side, i.e. change from 50:50 ratio and the local and remote views go away, and I can't get them back

My Fix:
In ContainerView class, replace the splitter class with libsyllable layoutnode class.

Diff Command:
[root@syllable:~/Develop/Transferrer]diff original/ fixed/
Common subdirectories: original/TestCases and fixed/TestCases
diff original/containerview.cpp fixed/containerview.cpp
1d0
< #include <gui/layoutview.h>
4,5d2
< #include <util/message.h>
<
18c15
< ContainerView::ContainerView(const os::Rect& cRect,const os::String& cName) : os::View(cRect,cName, os::CF_FOLLOW_ALL)
---
> ContainerView::ContainerView(const os::Rect& cRect,const os::String& cName) : os::LayoutView(cRect,cName)
40a38
> pcLeftRoot->SetBorders( Rect(4,2,2,2) );
49a48
> pcRightRoot->SetBorders( Rect(2,2,4,2) );
57c56
< // Create the splitter with the left and right side being the
---
> // Create the layoutview with the left and right side being the
59,60c58,61
< m_pcSplitter = new os::Splitter(GetBounds(),"splitter",pcLeft,pcRight,os::HORIZONTAL,os::CF_FOLLOW_ALL);
< AddChild(m_pcSplitter);
---
> HLayoutNode* pcRootNode = new HLayoutNode( "root_node" );
> pcRootNode->AddChild( pcLeft );
> pcRootNode->AddChild( pcRight );
> SetRoot( pcRootNode );
177a179,180
>
>
diff original/containerview.h fixed/containerview.h
4,5c4
< #include <gui/view.h>
< #include <gui/splitter.h>
---
> #include <gui/layoutview.h>
20c19
< class ContainerView : public os::View
---
> class ContainerView : public os::LayoutView
35,37d33
< /** \brief Vertical splitter bar. */
< os::Splitter* m_pcSplitter;
<
52a49
>
Common subdirectories: original/images and fixed/images
Common subdirectories: original/objs and fixed/objs
Back to top
View user's profile Send private message
Kaj
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 2207
Location: Friesland

PostPosted: Mon May 31, 2010 9:46 am    Post subject: Reply with quote

We always like bug reports with included patches. Smile Thanks!
Back to top
View user's profile Send private message Visit poster's website
Morph
The Knights of Syllable


Joined: 18 Oct 2007
Posts: 316
Location: Australia

PostPosted: Mon May 31, 2010 6:36 pm    Post subject: Reply with quote

Thanks for the patch! I think that was actually on the todo list somewhere Smile I'll check it in to the Transferrer CVS and do another build shortly.
Back to top
View user's profile Send private message Visit poster's website
Morph
The Knights of Syllable


Joined: 18 Oct 2007
Posts: 316
Location: Australia

PostPosted: Wed Jun 22, 2011 9:16 pm    Post subject: Reply with quote

It took a while, but I just did a new build with this patch applied Smile. The original intention of using a Splitter to divide the two views was that the user can drag the splitter to resize the views. But since this doesn't currently work, we can use a LayoutView instead until the Splitter problem is resolved. Get the new build here: http://forum.syllable.org/pmwiki/pmwiki.php?n=Projects.FTPClient
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    Syllable Forum Index -> Bugs - Fixed All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group