Syllable Forum Index Syllable
Syllable Forums
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

AIO worker ignores block cache

 
Post new topic   Reply to topic    Syllable Forum Index -> Bugs - Fixed
View previous topic :: View next topic  
Author Message
Vanders
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 849

PostPosted: Fri Apr 13, 2012 6:34 am    Post subject: AIO worker ignores block cache Reply with quote

I just noticed that do_aio_worker() uses read_pos_p() and write_pos_p() for the async I/O operations, which means it does not pass through the block cache. It should probably be using maybe_cached_read() and maybe_cached_write() instead (which will honour O_DIRECT into the bargain)
Back to top
View user's profile Send private message Send e-mail
Kaj
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 2201
Location: Friesland

PostPosted: Fri Apr 13, 2012 7:49 am    Post subject: Reply with quote

Noted. Any chance you could test it?
Back to top
View user's profile Send private message Visit poster's website
Vanders
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 849

PostPosted: Fri Apr 13, 2012 8:37 am    Post subject: Reply with quote

I'd have to have a machine running Syllable and a development environment for that :)
Back to top
View user's profile Send private message Send e-mail
Vanders
The Knights of Syllable


Joined: 14 Sep 2007
Posts: 849

PostPosted: Fri Apr 13, 2012 8:50 am    Post subject: Reply with quote

It's all right anyway, you can totally ignore this. I've confused read_pos_p() with read_phys_blocks(): read_pos_p() will hit maybe_cached_read() (& ditto write_pos_p()) inside AFS eventually anyway. Derp.
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Syllable Forum Index -> Bugs - Fixed All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group